Skip to content

Conversation

@crisbeto
Copy link
Member

We have an aria-expanded attribute on the tabpanel which is invalid. See https://w3c.github.io/aria/#aria-expanded.

Fixes #25637.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 15, 2022
@crisbeto crisbeto requested a review from mmalerba as a code owner September 15, 2022 07:24
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 16, 2022
@crisbeto crisbeto self-assigned this Sep 19, 2022
We have an `aria-expanded` attribute on the `tabpanel` which is invalid. See https://w3c.github.io/aria/#aria-expanded.

Fixes angular#25637.
@crisbeto crisbeto force-pushed the 25637/stepper-aria-expanded branch from 6c9c1ef to cbe6e68 Compare September 20, 2022 15:36
@crisbeto crisbeto merged commit 94c773d into angular:main Sep 21, 2022
crisbeto added a commit that referenced this pull request Sep 21, 2022
We have an `aria-expanded` attribute on the `tabpanel` which is invalid. See https://w3c.github.io/aria/#aria-expanded.

Fixes #25637.

(cherry picked from commit 94c773d)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Oct 5, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.2.2/14.2.3) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.2.2/14.2.3) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.2.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1423-wool-wombat-2022-09-28)

[Compare Source](angular/components@14.2.2...14.2.3)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [8c3d79156](angular/components@8c3d791) | fix | **bottom-sheet:** aria-modal not being set |
| [7d314a87b](angular/components@7d314a8) | fix | **dialog:** aria-modal not being set |
| [bc978445b](angular/components@bc97844) | fix | **stepper:** remove invalid aria attribute ([#&#8203;25644](angular/components#25644)) |
| [a9d3bc580](angular/components@a9d3bc5) | fix | **tooltip:** animations running when timeouts haven't elapsed ([#&#8203;25699](angular/components#25699)) ([#&#8203;25701](angular/components#25701)) |

#### Special Thanks

James Skinner, Kristiyan Kostadinov and Paul Gschwendtner

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMCIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1568
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug (Stepper Component) accessibility issue : The aria-expanded attribute is not allowed on this DIV

2 participants